added Zabbix / SNS patch & library Change / library Update#2
Merged
nsano-rururu merged 8 commits intojohnsusek:masterfrom Aug 8, 2020
nsano-rururu:zabbix-sns
Merged
added Zabbix / SNS patch & library Change / library Update#2nsano-rururu merged 8 commits intojohnsusek:masterfrom nsano-rururu:zabbix-sns
nsano-rururu merged 8 commits intojohnsusek:masterfrom
nsano-rururu:zabbix-sns
Conversation
Libracy Change joi 14.3.1 → @hapi/joi 17.1.1 Libracy Update joi ^14.3.1 → @hapi/joi ^17.1.1 @babel/cli ^7.10.1 → ^7.10.3 @babel/core ^7.10.2 → ^7.10.3 @babel/preset-env ^7.10.2 → ^7.10.3 @babel/register ^7.10.1 → ^7.10.3 bunyan ^1.8.12 → ^1.8.13 eslint ^7.2.0 → ^7.3.1
nsano-rururu
changed the title
nsano-rururu
changed the title
@babel/cli ^7.10.3 → ^7.10.4 @babel/core ^7.10.3 → ^7.10.4 @babel/preset-env ^7.10.3 → ^7.10.4 @babel/register ^7.10.3 → ^7.10.4 bunyan ^1.8.13 → ^1.8.14 eslint ^7.3.1 → ^7.4.0
@babel/cli ^7.10.4 → ^7.10.5 @babel/core ^7.10.4 → ^7.10.5 @babel/register ^7.10.4 → ^7.10.5 lodash ^4.17.15 → ^4.17.19 request-promise-native ^1.0.8 → ^1.0.9 ws ^7.3.0 → ^7.3.1 eslint ^7.4.0 → ^7.5.0 Review error handling src/common/file_system.js src/common/config/server_config.js src/controllers/config/index.js src/controllers/folders/index.js src/controllers/rules/index.js src/controllers/silence/index.js src/controllers/templates/index.js src/controllers/test/index.js
@babel/core ^7.10.5 → ^7.11.0 @babel/preset-env ^7.10.4 → ^7.11.0 eslint ^7.5.0 → ^7.6.0 mocha ~8.0.1 → ~8.1.0
Collaborator
Author
|
@johnsusek can you review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added SNS and Zabbix patches
Fix SNS Program & Docs #2793
YelpArchive/elastalert#2793
Bugfix and better error handling on zabbix alerter #2640
YelpArchive/elastalert#2640
library Change
changed to @hapi/joi as joi is deprecated
library Update
istanbul is deprecated and removed
It has been confirmed that there is currently no test code that acquires coverage.
Consider new coverage tools when it comes to writing test code in the future