added hour_range_enhancement in order to use time window feature#6
Merged
nsano-rururu merged 1 commit intojohnsusek:masterfrom Mar 16, 2021
Merged
added hour_range_enhancement in order to use time window feature#6nsano-rururu merged 1 commit intojohnsusek:masterfrom
nsano-rururu merged 1 commit intojohnsusek:masterfrom
Conversation
Collaborator
|
Thank you very much for this pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @johnsusek
My name is Abir and I am working with Praeco in my company (I am working with @osherdp if you remember him).
We wanted to send alerts only at ranged time during the day, so we developed a feature for Praeco.
The feature is called Time Window and the user can use it to send alerts only during specific time range.
I opened a pull request for Praeco: johnsusek/praeco#301
The feature in the mentioned pull request depends on the enhancement I added to elastalert_module in elastalert.
Please review the changes and merge it to Praeco so everyone will be able to use it.
Credits:
@abirsigron - my presonal account
@0xSeb for writing the enhancement: https://github.com/0xSeb/elastalert_hour_range