Skip to content

Conversation

@firewave
Copy link
Collaborator

No description provided.

@johnthagen
Copy link
Owner

I would recommend adding "Closes #70" to the PR description so that it will close that issue automatically on merge.

@firewave
Copy link
Collaborator Author

I would recommend adding "Closes #70" to the PR description so that it will close that issue automatically on merge.

That is already in the commit message.

@johnthagen johnthagen self-requested a review December 13, 2023 12:25
@firewave firewave merged commit 1034118 into johnthagen:master Dec 13, 2023
@firewave firewave deleted the java-dep branch December 13, 2023 15:17
@johnthagen
Copy link
Owner

@firewave 1.6.4 has been uploaded to JetBrains for moderation.

Thanks again for your work!

@firewave
Copy link
Collaborator Author

No problem. Let's hope it goes through this time.

The really big tasks are still to come ... 😫

@johnthagen
Copy link
Owner

johnthagen commented Dec 14, 2023

1.6.4 has been approved and released. 🚀

@firewave
Copy link
Collaborator Author

Something is wrong here:
image

It is not compatible with several IDEs including CLion.

And I once again forgot the newline in the release notes:
image

@johnthagen
Copy link
Owner

Perhaps the way compatibility is declared had changed?

<idea-version since-build="163.0"/>

@firewave
Copy link
Collaborator Author

Unlikely as that is the version of the underlying platform. I have the feeling it might be related to the added com.intellij.modules.java dependency.

I will do some local tests later on and contact the support if necessary.

@johnthagen
Copy link
Owner

johnthagen commented Dec 15, 2023

Yes, I can confirm that is it:

Screenshot 2023-12-15 084631

Since that compatibility issue only dealt with 2019.x, why don't we simply bump our minimum idea-version to the corresponding build version for 2020.x and revert the dependency we added in this PR? We could probably go even higher given that it's unlikely many users will be using anything older than 2022.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants