Conversation
Unable to test Oauth due to Cloudflare outage Known issue: save button doesn't work in preferences
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal was to break up AppModel.swift and DiscordService.swift into smaller services and reduce the amount of logic living in those files.
Major extractions
• Gateway parsing → GatewayEventDispatcher.swift
• WebSocket transport → DiscordGatewayConnection.swift
• Command execution → CommandProcessor.swift
• Rule pipeline → RuleExecutionService.swift
• AI → DiscordAIService.swift
• Wiki → WikiLookupService.swift
Discord REST split into clients
• DiscordMessageRESTClient
• DiscordGuildRESTClient
• DiscordInteractionRESTClient
• DiscordIdentityRESTClient
State stores extracted
• VoicePresenceStore (app-side voice tracking)
• VoiceRuleStateStore (Discord rule timing state)
Safety / architecture guarantees kept intact
• SwiftMesh ownership unchanged (AppModel+Gateway.swift still owns mesh sync + requests)
• Dual output safety model preserved:
• ActionDispatcher.canSend
• DiscordService.outputAllowed
Facade cleanup
AppModel now shares AI, wiki, identity, message, and guild clients directly, so read-only operations no longer route through DiscordService. Output helpers (typing, reactions, pin/unpin, threads) now go through the same guarded send path.
Testing
Throughout the refactor I repeatedly ran:
• swift build
• targeted unit tests for new services
• mesh safety gates:
• MeshSyncTests
• MeshFailoverTests
• ClusterSecurityTests
Overall result: DiscordService is now significantly slimmer and the codebase is much more modular.