Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and changes across the codebase, primarily focused on note ID generation, validation logic, and improved robustness for note handling. The most significant updates are the new word-based note ID scheme, stricter validation, enhanced auto-save logic in the frontend, and corresponding updates to tests and workflows.
Note ID Generation and Validation
utils.go,utils_test.go) [1] [2]"test123"with"TEST23") and added/adjusted test cases to reflect the stricter validation and new ID structure. (handlers_test.go,storage_test.go,utils_test.go) [1] [2] [3]Backend Logic and Robustness
Content-Type: application/x-www-form-urlencoded(as withcurl --data-binary), the note ID is still correctly extracted from the path. Added a test to verify this behavior. (handlers.go,handlers_test.go) [1] [2]Frontend Auto-save Improvements
savingflag, ensuring that a new save is not started until the previous one completes. This prevents race conditions and potential data loss. (handlers.go) [1] [2] [3]CI/CD Workflow Adjustments
golangbranch instead ofmainordev, reflecting a shift in the primary development branch for both deployment and testing. (.github/workflows/deploy-lambda.yml,.github/workflows/test.yml) [1] [2]These changes collectively improve the reliability, usability, and maintainability of the note-taking service, especially around note identification and storage.