Skip to content

extract route management into dedicated manager#166

Merged
mrabine merged 2 commits intomainfrom
165-extract-route-management-into-a-dedicated-routemanager-class
Mar 17, 2026
Merged

extract route management into dedicated manager#166
mrabine merged 2 commits intomainfrom
165-extract-route-management-into-a-dedicated-routemanager-class

Conversation

@mrabine
Copy link
Collaborator

@mrabine mrabine commented Mar 17, 2026

No description provided.

@mrabine mrabine linked an issue Mar 17, 2026 that may be closed by this pull request
@codacy-production
Copy link

codacy-production bot commented Mar 17, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% 97.13%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0758a90) 10222 9845 96.31%
Head commit (5fea6d9) 10404 (+182) 10018 (+173) 96.29% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#166) 349 339 97.13%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 96.93252% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.32%. Comparing base (0758a90) to head (5fea6d9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
fabric/src/routemanager.cpp 96.29% 8 Missing ⚠️
fabric/include/join/route.hpp 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   96.35%   96.32%   -0.04%     
==========================================
  Files          84       88       +4     
  Lines        9557     9720     +163     
==========================================
+ Hits         9209     9363     +154     
- Misses        348      357       +9     
Flag Coverage Δ
unittests 96.32% <96.93%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Mar 17, 2026

Pull Request Test Coverage Report for Build 23172285380

Details

  • 339 of 349 (97.13%) changed or added relevant lines in 8 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 96.29%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fabric/include/join/route.hpp 22 24 91.67%
fabric/src/routemanager.cpp 225 233 96.57%
Files with Coverage Reduction New Missed Lines %
fabric/src/interfacemanager.cpp 2 99.11%
Totals Coverage Status
Change from base Build 23168690555: -0.02%
Covered Lines: 10018
Relevant Lines: 10404

💛 - Coveralls

@mrabine mrabine merged commit 5f9f5cf into main Mar 17, 2026
15 checks passed
@mrabine mrabine deleted the 165-extract-route-management-into-a-dedicated-routemanager-class branch March 17, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract route management into a dedicated RouteManager class

2 participants