Skip to content

Add DNS over TLS support#187

Merged
mrabine merged 9 commits intomainfrom
186-add-dns-over-tls-dot-support
Apr 23, 2026
Merged

Add DNS over TLS support#187
mrabine merged 9 commits intomainfrom
186-add-dns-over-tls-dot-support

Conversation

@mrabine
Copy link
Copy Markdown
Collaborator

@mrabine mrabine commented Apr 17, 2026

No description provided.

@mrabine mrabine linked an issue Apr 17, 2026 that may be closed by this pull request
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 17, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 176 complexity · 2 duplication

Metric Results
Complexity 176
Duplication 2

View in Codacy

🟢 Coverage 89.33% diff coverage · -0.05% coverage variation

Metric Results
Coverage variation -0.05% coverage variation
Diff coverage 89.33% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6799fe2) 10801 10409 96.37%
Head commit (2717a2a) 11054 (+253) 10647 (+238) 96.32% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#187) 403 360 89.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 89.34010% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.30%. Comparing base (6799fe2) to head (2717a2a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
fabric/include/join/resolver.hpp 80.55% 42 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   96.36%   96.30%   -0.07%     
==========================================
  Files          91       90       -1     
  Lines       10129    10369     +240     
==========================================
+ Hits         9761     9986     +225     
- Misses        368      383      +15     
Flag Coverage Δ
unittests 96.30% <89.34%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 17, 2026

Coverage Report for CI Build 24862893637

Coverage decreased (-0.05%) to 96.318%

Details

  • Coverage decreased (-0.05%) from the base build.
  • Patch coverage: 43 uncovered changes across 1 file (360 of 403 lines covered, 89.33%).
  • 1 coverage regression across 1 file.

Uncovered Changes

File Changed Covered %
fabric/include/join/resolver.hpp 221 178 80.54%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
fabric/include/join/resolver.hpp 1 87.94%

Coverage Stats

Coverage Status
Relevant Lines: 11054
Covered Lines: 10647
Line Coverage: 96.32%
Coverage Strength: 112836.08 hits per line

💛 - Coveralls

@mrabine mrabine merged commit faf6e57 into main Apr 23, 2026
21 of 24 checks passed
@mrabine mrabine deleted the 186-add-dns-over-tls-dot-support branch April 23, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add DNS over TLS (DoT) Support

2 participants