Skip to content

Implement Name Server for DNS over UDP#189

Open
mrabine wants to merge 2 commits intomainfrom
188-implement-nameserver-for-dns-over-udp
Open

Implement Name Server for DNS over UDP#189
mrabine wants to merge 2 commits intomainfrom
188-implement-nameserver-for-dns-over-udp

Conversation

@mrabine
Copy link
Copy Markdown
Collaborator

@mrabine mrabine commented Apr 29, 2026

No description provided.

@mrabine mrabine linked an issue Apr 29, 2026 that may be closed by this pull request
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 29, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 24 complexity · 1 duplication

Metric Results
Complexity 24
Duplication 1

View in Codacy

🟢 Coverage 94.29% diff coverage · -0.02% coverage variation

Metric Results
Coverage variation -0.02% coverage variation
Diff coverage 94.29% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (faf6e57) 11052 10646 96.33%
Head commit (48571ac) 11104 (+52) 10694 (+48) 96.31% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#189) 70 66 94.29%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 93.84615% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.29%. Comparing base (faf6e57) to head (48571ac).

Files with missing lines Patch % Lines
fabric/include/join/nameserver.hpp 90.69% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
- Coverage   96.31%   96.29%   -0.03%     
==========================================
  Files          90       91       +1     
  Lines       10369    10414      +45     
==========================================
+ Hits         9987    10028      +41     
- Misses        382      386       +4     
Flag Coverage Δ
unittests 96.29% <93.84%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 29, 2026

Coverage Report for CI Build 25138081566

Coverage decreased (-0.02%) to 96.308%

Details

  • Coverage decreased (-0.02%) from the base build.
  • Patch coverage: 4 uncovered changes across 1 file (66 of 70 lines covered, 94.29%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
fabric/include/join/nameserver.hpp 48 44 91.67%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 11104
Covered Lines: 10694
Line Coverage: 96.31%
Coverage Strength: 111096.32 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement NameServer for DNS over UDP

2 participants