Skip to content

Add write handler support to Reactor#195

Merged
mrabine merged 9 commits into
mainfrom
194-add-write-handler-support-to-reactor
May 13, 2026
Merged

Add write handler support to Reactor#195
mrabine merged 9 commits into
mainfrom
194-add-write-handler-support-to-reactor

Conversation

@mrabine
Copy link
Copy Markdown
Collaborator

@mrabine mrabine commented May 12, 2026

No description provided.

@mrabine mrabine linked an issue May 12, 2026 that may be closed by this pull request
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 12, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 11 complexity · 13 duplication

Metric Results
Complexity 11
Duplication 13

View in Codacy

🟢 Coverage 100.00% diff coverage · +0.08% coverage variation

Metric Results
Coverage variation +0.08% coverage variation
Diff coverage 100.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f176dd1) 11345 10954 96.55%
Head commit (6c8330c) 11350 (+5) 10968 (+14) 96.63% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#195) 39 39 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.64%. Comparing base (f176dd1) to head (6c8330c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   96.55%   96.64%   +0.08%     
==========================================
  Files          91       91              
  Lines       10639    10642       +3     
==========================================
+ Hits        10273    10285      +12     
+ Misses        366      357       -9     
Flag Coverage Δ
unittests 96.64% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Copy Markdown

coveralls commented May 12, 2026

Coverage Report for CI Build 25804854324

Coverage increased (+0.08%) to 96.634%

Details

  • Coverage increased (+0.08%) from the base build.
  • Patch coverage: 39 of 39 lines across 7 files are fully covered (100%).
  • 2 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

2 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
core/src/reactor.cpp 2 97.94%

Coverage Stats

Coverage Status
Relevant Lines: 11350
Covered Lines: 10968
Line Coverage: 96.63%
Coverage Strength: 116503.77 hits per line

💛 - Coveralls

@mrabine mrabine merged commit 4d96723 into main May 13, 2026
15 checks passed
@mrabine mrabine deleted the 194-add-write-handler-support-to-reactor branch May 13, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add write handler support to Reactor

2 participants