Skip to content

Conversation

@mrabine
Copy link
Collaborator

@mrabine mrabine commented Dec 7, 2025

No description provided.

@codacy-production
Copy link

codacy-production bot commented Dec 7, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% 98.65%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1d0ab67) 9192 8882 96.63%
Head commit (ac901ef) 9202 (+10) 8889 (+7) 96.60% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#92) 148 146 98.65%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

❌ Patch coverage is 98.63946% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.68%. Comparing base (1d0ab67) to head (ac901ef).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
join/sax/include/join/json.hpp 98.38% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   96.71%   96.68%   -0.04%     
==========================================
  Files          71       71              
  Lines        8592     8604      +12     
==========================================
+ Hits         8310     8319       +9     
- Misses        282      285       +3     
Flag Coverage Δ
unittests 96.68% <98.63%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Dec 7, 2025

Pull Request Test Coverage Report for Build 20005715047

Details

  • 146 of 148 (98.65%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 96.599%

Changes Missing Coverage Covered Lines Changed/Added Lines %
join/sax/include/join/json.hpp 123 125 98.4%
Files with Coverage Reduction New Missed Lines %
join/sax/include/join/json.hpp 3 91.37%
Totals Coverage Status
Change from base Build 19948941552: -0.03%
Covered Lines: 8889
Relevant Lines: 9202

💛 - Coveralls

@mrabine mrabine merged commit 2da7622 into main Dec 7, 2025
12 checks passed
@mrabine mrabine deleted the improve_json_parsing branch December 7, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants