fix(dev): correct jm-ng websocket port#1237
Merged
theborakompanioni merged 1 commit intov2-jm-ngfrom May 3, 2026
Merged
Conversation
theborakompanioni
added a commit
that referenced
this pull request
May 5, 2026
…#1240) * chore(regtest): initial joinmarket-ng backend for regtest environment Adds jmwalletd, directory servers, makers, and bitcoind to the regtest docker-compose environment so jam can be developed against the jm-ng backend end-to-end. chore(regtest): wire docker compose env and vite dev proxy for jm-ng Connects the local regtest containers into a single compose network, adds tor and fund-wallet helpers, and points Vite's dev proxy at the local jmwalletd instance. fix(tags): recognize cj-change, used-empty, and flagged UTXO statuses joinmarket-ng's WalletService emits four statuses jam's JmPlainTagValue didn't cover: 'cj-change' (deanonymising change from our CJ), 'used-empty' (previously-used address with zero balance), and 'flagged' (address shared in a CJ that later failed). They fell through to the generic 'default' badge with no distinguishing styling. Add them to JmPlainTagValue and the status->variant map. 'used-empty' maps to the existing 'used' variant, 'flagged' to 'reused' (both signal a used address the user should avoid reusing). Add a dedicated 'cj-change' badge variant (emerald) next to 'cj-out' so the deanonymising change output is visually distinct from an equal-amount CJ output. fix(send): keep direct send available with maker Only block collaborative sends while the maker service is running. Direct sends stay enabled and the form explains why the collaborative toggle is unavailable. Changelog: Allow direct sends while the maker service is running docs(dev): explain jm-ng backend workflow fix(auth): only clear auth on invalid_token 401s Previously every 401 response cleared the session and logged the user out. jm-ng returns 401 for service-state errors (e.g. POST /tumbler/stop when nothing is running), which should never drop the session. Inspect the WWW-Authenticate header and only clear auth when the server signals ``error="invalid_token"``. Changelog: Non-auth 401 responses no longer log the user out. fix(dev): proxy /jmws to the jm-ng HTTPS port jm-ng serves WebSocket on the same port as the HTTPS API. The `jm-ng:dev` script used to override JMWALLETD_WEBSOCKET_PORT to 32283, but the regtest stack exposes that port without a matching listener, so vite proxied WebSocket upgrades into a dead port and the handshake returned empty. Default the env var to JMWALLETD_API_PORT and drop the override. Changelog: Fix WebSocket proxying in the local jm-ng dev setup. fix(dev): correct jm-ng websocket port and proxy targets Update the README and developer docs to reflect that both ports must be set when overriding for a custom jm-ng setup. fix(dev): correct jm-ng websocket port (#1237) chore(dev): distinct server configs for various backends * chore(regtest): address jm-ng review comments --------- Co-authored-by: m0wer <m0wer@sgn.space> Co-authored-by: Parth Bandwal <143504541+parrth20@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.