Replace Makefile with Castor task runner#64
Conversation
|
Hey do NOT Add Castor as a dev dependency in composer.json ! That's a developer tool. |
Co-authored-by: damienalexandre <225704+damienalexandre@users.noreply.github.com>
Co-authored-by: damienalexandre <225704+damienalexandre@users.noreply.github.com>
|
@copilot add |
Co-authored-by: pyrech <2021641+pyrech@users.noreply.github.com>
Confirmed - Castor is not in composer.json. It's documented as a standalone PHAR tool that developers install separately. |
Co-authored-by: damienalexandre <225704+damienalexandre@users.noreply.github.com>
|
@copilot use castor in the github action to the cs fixer and phpstan, you can use the "castor-php/setup-php" marketplace action to install castor |
Co-authored-by: joelwurtz <90466+joelwurtz@users.noreply.github.com>
Done in 7d665db. Updated the check-cs and phpstan jobs to use the castor-php/setup-castor@v1 action and run Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Would have been so much cheaper and faster to do this by hand omg.
@copilot you need to read the documentation : https://castor.jolicode.com/installation/github-action/ |
Co-authored-by: damienalexandre <225704+damienalexandre@users.noreply.github.com>
Fixed in 872b0bf. Updated to use Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: Jorick <48644518+JorickPepin@users.noreply.github.com>
Co-authored-by: Loïck Piera <pyrech@gmail.com>
Co-authored-by: damienalexandre <225704+damienalexandre@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot fix the CS |
Co-authored-by: damienalexandre <225704+damienalexandre@users.noreply.github.com>
Replace Makefile with Castor ✅
Summary
Successfully replaced the Makefile with Castor task runner. All existing Make tasks have been converted to Castor tasks maintaining the same functionality:
make cs→castor csmake cs_dry_run→castor cs --dry-runmake test→castor testmake phpstan→castor phpstanThe
cstask now accepts a--dry-runoption to check coding standards without fixing them, avoiding code duplication.Documentation links to official Castor installation guide. The castor.php file is excluded from PHPStan analysis as it's a build/developer tool file.
GitHub Actions CI workflows use Castor via the
castor-php/setup-castor@v1.0.0action for CS and PHPStan checks, replacing the previous Docker-based actions.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.