Skip to content

feat: programmatic discriminator mappings#295

Closed
robertvansteen wants to merge 1 commit intojolicode:mainfrom
robertvansteen:programatic-discriminator-mappings
Closed

feat: programmatic discriminator mappings#295
robertvansteen wants to merge 1 commit intojolicode:mainfrom
robertvansteen:programatic-discriminator-mappings

Conversation

@robertvansteen
Copy link

No description provided.

@joelwurtz
Copy link
Member

Hey thanks for the initial work on this.

We made change to support this in #319 it will be available in next major version.

I'm closing this, but if you feel like the DX or other things does not work for this feature please let us know.

@joelwurtz joelwurtz closed this Jan 28, 2026
@robertvansteen
Copy link
Author

Hey thanks for the initial work on this.

We made change to support this in #319 it will be available in next major version.

I'm closing this, but if you feel like the DX or other things does not work for this feature please let us know.

@joelwurtz thanks! Good to see this being added. The main reason for starting this work was that I ran into a challenge where the interface is in vendor so I won't be able to add any attribute on it. Do you see this being supported in some way?

@joelwurtz
Copy link
Member

The main reason for starting this work was that I ran into a challenge where the interface is in vendor

Both source and target are in vendor ?
But yes this a global problem if source is in vendor and target is an array (or also in vendor) or the reverse situation.

For that we are open to a more global feature that allow defining mapper configuration without any attribute. The main work for this would be on the DX (how the developer will interact with this configuration). I'm open to do the work if there is a nice proposition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants