fix(ships): use current timestamp in zero-deleted cleanup test#2007
Merged
jomcgi merged 1 commit intotest/ships-backend-coveragefrom Apr 11, 2026
Merged
fix(ships): use current timestamp in zero-deleted cleanup test#2007jomcgi merged 1 commit intotest/ships-backend-coveragefrom
jomcgi merged 1 commit intotest/ships-backend-coveragefrom
Conversation
The test was using a hardcoded timestamp from 2024-03-01 which is well outside the 7-day retention window, causing the position to be deleted and the assertion to fail. Replace with datetime.now() so the timestamp is always within the retention window. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_zero_deleted_returns_zero_and_no_position_count_change2024-03-01timestamp which is >2 years old (outside 7-day retention window), causing the position to be deleteddatetime.now(timezone.utc).isoformat()so the timestamp is always within the retention windowTest plan
bb remote test //projects/ships/backend/tests:unit_testpasses (all 146 tests)🤖 Generated with Claude Code