Merged
Conversation
This was referenced Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is heavily inspired by #51 and #59 to arrive at something I think both PR authors would like. The ultimate goal is to provide better support for configuring the gem in whichever way is more desired. I updated the README to illustrate how either instance-level configuration settings could be used or global ones instead. Then I updated the
BrazeRuby::API.newmethod signature to not require any arguments.From there I blended those PR approaches to arrive at a simple solution:
Then I added specs which caused me to have to add a
BrazeRuby.resetmethod so that test state did not leak between runs.That's it! Thanks so much to @gerbal and @hugolepetit for their ideas that lead me here and sorry it took literal years. 😬