Extract helper to format values in attr table#295
Merged
jonallured merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR the formatting of values in the attr tables used in the CRUD pages section were spread out into the various models. For example, any timestamps would be formatted in the model file with a call to
.to_fsand if there was a value that could be nil then I had to use the safe navigation operator. This was silly!What this PR does is extract a helper method called
attr_table_valuethat takes the value and then applies this logic:NILto_fson itThis really cleaned things up and relocated the formatting to the view layer rather than the model layer. It also gives me a single place to change these things should I so desire. Foreshadowing!