fix: use clientX/clientY in drag-and-drop system#2
Merged
Conversation
The drag system compared pageX/pageY (page-relative) coordinates against getBoundingClientRect() values (viewport-relative), causing incorrect drop targets and positions when the page was scrolled. Switch to clientX/clientY throughout to match the client coordinate space. Fixes BUG-001. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jonathan-beebe
force-pushed
the
fix/001-drag-drop-page-vs-client-coords
branch
from
7bcf0b5 to
1e404f6
Compare
✅ Deploy Preview for golden-scone-6bfeb1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pageX/pageYtoclientX/clientYto matchgetBoundingClientRect()viewport-relative spaceDragStartInfointerface,useDragAndDrophook, andCardcomponentTest plan
🤖 Generated with Claude Code