Added etstool.py (only install and flake8 work) #46
Conversation
Added the etstool.py file and modified it for the tutorial. Only the `install` function is guaranteed to work currently. Will continue work on this for all `setup.py` files next. Also altered the `README.md` to reflect changes in environment creation.
chamshop
changed the title
|
Added |
|
Thanks @chamshop . Is this ready for review or not yet? |
siddhantwahal
left a comment
siddhantwahal
left a comment
There was a problem hiding this comment.
I think it'll be nice if tutorial attendees could also use these commands. That way, everyone gets a standardized environment and we mitigate the risk of someone forgetting or mistyping commands.
| "matplotlib", | ||
| "pandas", | ||
| "pillow", | ||
| "pyqt5", |
There was a problem hiding this comment.
I think we should explicitly declare pyface as a dependency, since we directly import from it. We're currently pulling pyface implicitly, probably through traitsui.
ci/__main__.py
Outdated
| "edm run -e {environment} -- pip install pyside6<6.2.2") | ||
| else: | ||
| commands.append("edm run -e {environment} -- pip install pyside6") | ||
| elif toolkit == 'wx': |
There was a problem hiding this comment.
My vote would be to not support the wx backend.
ci/__main__.py
Outdated
|
|
||
| # pip install pyqt5, pyqt6, pyside2 and pyside6, because we don't have them | ||
| # in EDM yet | ||
| if toolkit == 'pyside2': |
There was a problem hiding this comment.
pyside2 is now available in EDM, or at least version 5.14.
There was a problem hiding this comment.
Ok, will remove this special consideration.
ci/__main__.py
Outdated
| elif toolkit == 'pyqt6': | ||
| commands.append("edm run -e {environment} -- pip install pyqt6") | ||
| elif toolkit == 'pyside6': | ||
| # On Linux and macOS, some versions of PySide6 between 6.2.2 and 6.3.0 | ||
| # are unimportable on Python 3.6 and Python 3.7. See | ||
| # https://bugreports.qt.io/browse/PYSIDE-1797. It may be possible to | ||
| # remove this workaround once PySide6 6.3.1 or later is released. | ||
| if sys.platform in {'darwin', 'linux'}: | ||
| commands.append( | ||
| "edm run -e {environment} -- pip install pyside6<6.2.2") | ||
| else: | ||
| commands.append("edm run -e {environment} -- pip install pyside6") |
There was a problem hiding this comment.
I'm still not sure about why we would need this logic. If we expect tutorial attendees to use the CI module, then allowing them to specify the toolkit can be a useful escape hatch if pyqt5 doesn't work for them.
There was a problem hiding this comment.
Hey @siddhantwahal , I'm not sure I understand your meaning here...
ci/__main__.py
Outdated
| click.echo("Creating environment '{environment}'".format(**parameters)) | ||
| execute(commands, parameters) | ||
|
|
||
| if source: |
There was a problem hiding this comment.
We don't need this if block either as we don't want to install any packages from source.
ci/__main__.py
Outdated
| help="Install main package in 'editable' mode? [default: --not-editable]", | ||
| ) | ||
| @click.option('--source/--no-source', default=False) | ||
| def install(runtime, toolkit, environment, editable, source): |
There was a problem hiding this comment.
When run as is, this command will install the ets_tutorial package, and not any of the application ones. It'll be useful to document this fact. And perhaps "setup" or "build" would be a better name for this command.
There was a problem hiding this comment.
Great idea. Will change to "setup".
There was a problem hiding this comment.
Actually going to change it to "build", to avoid any confusion with setuptools "setup".
|
@jonathanrocher This should be ready as an environment builder and flake8 runner. Need to add the ability to run |
|
This is great @chamshop . ci install and ci flake8 are all we need. Don't worry about |
Added the etstool.py file and modified it for the tutorial. Only the
installfunction is guaranteed to work currently. Will continue work on this for allsetup.pyfiles and tests next.Also altered the
README.mdto reflect changes in environment creation.