Fix KeyError in image folder view in Stage 5.3#58
Merged
jonathanrocher merged 1 commit intomasterfrom Jul 11, 2022
Merged
Conversation
siddhantwahal
commented
Jul 9, 2022
Comment on lines
+129
to
+132
| def parse_year(x): | ||
| return x.split(":")[0] if isinstance(x, str) else "unknown" | ||
| data[YEAR_KEY] = data[DATETIME_COL].apply(parse_year) | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
This isn't necessary to fix the bug but I accidentally included it in this commit. I'll let it be here because all missing columns are now added in one place so it's slightly easier to follow.
siddhantwahal
commented
Jul 9, 2022
| def _filtered_data_default(self): | ||
| return self.all_data | ||
|
|
||
| def _all_years_default(self): |
Collaborator
Author
There was a problem hiding this comment.
This and filtered_data could be properties, but this is OK too.
siddhantwahal
changed the title
KeyError in image folder view in Stage 5.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce:
ets_tutorial/ets_tutorial/sample_imagesin the browser paneKeyError: "Make".That's because computing faces updates
all_databut neglects to add missing columns to it.