Add Nav component with title of current Kata #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one solution to addressing the problem where we want to be able to know the name of the current Kata in order to know which file to edit. Some of the Katas have `<Text />` labels with their names which works very well. However, for some Katas, the `<Text />` would interfere with the styling of the Kata itself. This approach instead adds a Nav bar at the top of the Kata runner in the simulator. This allows us to both see the name of the current Kata as well as render the Kata without interference. * Install NavigationBar from react-native-navbar * Create own Nav component wrapping NavigationBar * Wrap runner in View with Nav and Kata as children
Owner
|
Excellent! I love the solution with navigator and the forward-thinking! :) |
jondot
added a commit
that referenced
this pull request
Jun 25, 2016
ian-aguilar
added a commit
to ian-aguilar/ReactNativeKatas
that referenced
this pull request
Oct 4, 2024
pavlobuhii414
added a commit
to pavlobuhii414/ReactNative-Project
that referenced
this pull request
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one solution to addressing the problem where we want to be able to know the name of the current Kata in order to know which file to edit.
Some of the Katas have
<Text />labels with their names which works very well. However, for some Katas, the<Text />would interfere with the styling of the Kata itself.This approach instead adds a Nav bar at the top of the Kata runner in the simulator. This allows us to both see the name of the current Kata as well as render the Kata without interference.
NavigationBarfromreact-native-navbarNavcomponent wrappingNavigationBarRunnerin<View />withNavand Kata as children