fix: wave 5 - security hardening, CI permissions, and test health#280
Merged
Conversation
Contributor
|
🚀 Website Preview
Preview has been cleaned up as the PR was closed. |
Security (#270): - Fix pr-build.yml pull_request_target to checkout base SHA - Add command allowlist validation in reqs.go for exec.CommandContext - Harden dashboard sanitizeHtml against iframe/object/embed/base/link XSS - Fix codeql.yml: remove continue-on-error, enable SARIF upload - Add explicit permissions blocks to ci.yml and release.yml - Pin govulncheck to v1.1.4 in govulncheck.yml - Enforce codecov patch coverage at 60% - Add timeout-minutes to sync-demo-template smoke-test - Note extension.yaml vs registry.json version discrepancy Test health (#275): - Replace time.Sleep with require.Eventually in state_monitor_test.go - Replace time.Sleep in notifications/pipeline_test.go - Add t.Parallel() to logbuffer_context_test.go and query_builder_test.go Closes #270, #275 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add pnpm.overrides to web/package.json to match lockfile yaml security fix - Fix dashboard-dist artifact path in ci.yml: cli/dashboard/dist/ → cli/src/internal/dashboard/dist/ (matches vite outDir and Go embed) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
force-pushed
the
swarm/wave-5-quality-tests
branch
2 times, most recently
from
f8a858e to
b86e01e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 5: Security, CI, and Test Health
Issues Resolved
Security Fixes (#270)
eqs.go\ for \�xec.CommandContext\ calls
CI/Config Fixes (#270)
Test Health (#275)
equire.Eventually\ in state_monitor_test.go and pipeline_test.go
Deferred (requires manual review)
Closes #270, #275