fix: MQ Wave 1 security hardening and code review fixes#288
Merged
Conversation
Security hardening: - Add RPC session token authentication (X-Session-Token header) - Restrict healthcheck URLs to localhost only (SSRF prevention) - Add log secret masking for file output (key=value, JWT patterns) - Dashboard fetches and injects session token via Connect interceptor Code review fixes: - Fix operator precedence in isFileLockingError (gate on Windows first) - Replace time.Sleep with context-aware select in retry loop - Fix stderr double-wrapping on installer retry - Propagate context through hook execution chain - Add nil-check for LogsStoreFuncs in NewLogsHandler - Extract updateRegistryWithRetry helper (dedup ~40 lines) - Sanitize serviceName with filepath.Base in logbuffer Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MQ Wave 1 identified 1 CRITICAL, 4 HIGH, and 5 MEDIUM findings. This PR fixes all of them.
Security Hardening
Code Review Fixes
Verification