Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 80.53% 81.12% +0.58%
==========================================
Files 12 12
Lines 935 964 +29
==========================================
+ Hits 753 782 +29
Misses 140 140
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a domain validation function that checks for various criteria, including format, length, and the absence of protocols or ports. Comprehensive test cases ensure the function behaves as expected.
Linked Issue
Fixes # (if applicable)
Checklist
Tests pass:
go test ./...Formatted:
gofmt -s -w .Vetted:
go vet ./...Docs updated (README/CHANGELOG/etc.) if needed
Notes
Reviewers should focus on the validation logic and the thoroughness of the test cases.