fix: quality sweep — code review, security, and docs fixes#115
Merged
Conversation
- chronicle.go: prevent goroutine blocking by respecting ctx.Done in PTY reader - dbwatch.go: recover panics in onChange callback to keep watcher alive - plans.go: tighten session-state dir permissions from 0755 to 0700 - store.go: log searchRefs DB errors instead of silently swallowing them - update.go: clean up partial file on copyFile write failure Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The CLI flag was renamed to --reindex but the README still referenced the old --rebuild-index name. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Max-quality sweep across the entire codebase. All gates pass clean (build, test, vet, lint, gofumpt, govulncheck, deadcode).
Changes
Code fixes:
Docs:
Verification
All pass: go build, go test (13 packages), go vet, golangci-lint, gofumpt, govulncheck, mage install