Swarm: resolve issues #87-#94 (architecture, tests, performance, CI, quality) by jongio · Pull Request #95 · jongio/dispatch

jongio · 2026-05-17T19:32:11Z

Summary

Combined PR resolving 8 meta-issues covering architecture, code quality, performance, CI/CD, test health, idiomatic Go, goroutine safety, and repo health improvements.

Issues Resolved

Closes Architecture: layering, coupling, and structural findings #87: Architecture, layering, coupling, and structural findings
Closes Test health: coverage gaps across packages #88: Test health, coverage gaps across packages
Closes Performance: data layer and rendering improvements #89: Performance, data layer and rendering improvements
Closes CI/CD: configuration and reproducibility improvements #90: CI/CD, configuration and reproducibility improvements
Closes Idiomatic Go: pattern modernization findings #91: Idiomatic Go, pattern modernization findings
Closes Quality: goroutine leaks, context handling, and dependency fixes #92: Quality, goroutine leaks, context handling, and dependency fixes
Closes Code quality: deduplication and small refactors #93: Code quality, deduplication and small refactors
Closes Repo health: dependency automation and security docs #94: Repo health, dependency automation and security docs

Changes (60 files, +3805/-1401)

Architecture (#87): Split model.go, decomposed Model struct, extracted Update handlers, fixed layering violations, added interface abstractions.

Test Health (#88): Added coverage for platform, work status, copilot analyze, update replace, chronicle PTY, dbwatch. Fixed meaningless test assertions.

Performance (#89): Added DB index, parallelized queries, cached render strings, replaced subqueries with JOINs, reused HTTP client.

CI/CD (#90): Full ./... compilation, pinned linter version, updated action versions, consistent Go version.

Idiomatic Go (#91): errors.Is/As, sync.RWMutex for styles, context propagation, sentinel errors in tests, panic logging.

Quality (#92): Context cancellation in closeStore, goroutine leak fix, noctx linter re-enabled.

Code Quality (#93): Deduplicated filter methods, attention scanning, dot rendering, plan parsing, font detection. Extracted model constant.

Repo Health (#94): Dependabot config, SECURITY.md network disclosure.

Quality Gates

go build ./... pass
go test ./... -count=1 pass (13 packages)
go vet ./... pass

#70 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ixes #72 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…tant - Fixes #81 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…r - Fixes #80 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ixes #68 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ixes #68 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…se - Fixes #75 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ere possible - Fixes #59 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…aseline - Fixes #86 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…n - Fixes #82 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…84 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

# Conflicts: # .github/workflows/release.yml # internal/tui/components/sessionlist.go

# Conflicts: # internal/data/chronicle_windows_test.go # internal/data/dbwatch_test.go

…Wave 1 merge Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…#79 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Fixes #64, Fixes #65 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

# Conflicts: # internal/tui/model.go

…Dot helper - Fixes #40 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…r helper - Fixes #39 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… predicate helper - Fixes #34 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… possible - Fixes #50 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…gate where safe - Fixes #52 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ntinel errors Add sentinel error variables to copilot, update, and platform packages. Wrap production error returns with sentinels using fmt.Errorf with wrapping. Replace 49 strings.Contains(err.Error(),...) test assertions with errors.Is. Fixes #53

# Conflicts: # internal/data/store.go

# Conflicts: # internal/tui/model.go

# Conflicts: # internal/update/update.go # internal/update/update_test.go

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jongio · 2026-05-17T19:40:16Z

PR Review Summary

Verdict: COMMENT (self-review)

Reviewed 59 changed files (+3,805/-1,402) across 4 waves resolving 40 issues. Build, tests, vet, and lint all pass (mage preflight clean).

Security: PASS - No blocking issues. Net improvement.

Code Quality: PASS - errgroup correct, handlers extraction clean, model decomposition correct.

Non-Blocking Follow-ups

Consider --require-cosign env var for install scripts
Consider requiring approval on auto CONTRIBUTORS.md PRs
Add ctx to Maintain() for consistency
Pin actions/upload-artifact to SHA

…pliance Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

# Conflicts: # internal/tui/model.go

- copilot: accept any error from unstarted SDK (platform-dependent) - update: wrap 'no checksum found' with ErrChecksumMismatch sentinel - data: use exec.CommandContext in chronicle_unix.go for noctx Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… group filters - closeStore now cancels copilotSearchCancel and workStatusAICancel before shutting down, preventing goroutine leaks when the TUI exits with active SDK searches or AI analyses in flight - handleDeepSearchResult groups branch now applies filterAttentionGroups, filterPlanGroups, and filterWorkStatusGroups, matching the filter chain in handleGroupsLoaded Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

# Conflicts: # go.mod # go.sum

jongio and others added 30 commits May 16, 2026 23:10

docs: align Go version in CONTRIBUTING.md with go.mod (1.26.3+) - Fixes

4de84f5

#70 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

chore(deps): add Dependabot config for Go, Actions, and npm - Fixes #71

b574e06

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

docs(security): document all network-facing features in SECURITY.md - F…

b4ef060

…ixes #72 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

refactor(copilot): extract hardcoded model name to package-level cons…

4506adb

…tant - Fixes #81 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

refactor(platform): deduplicate Nerd Font detection into shared helpe…

d94561b

…r - Fixes #80 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

ci(actions): align pages.yml action versions with other workflows - F…

af5cfaf

…ixes #68 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

perf(tui): cache padding string in session list render loop - Fixes #62

721d81e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

ci(actions): align pages.yml action versions with other workflows - F…

7f5a769

…ixes #68 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

ci(security): use PR workflow instead of direct push to main in relea…

50d1a34

…se - Fixes #75 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

chore(deps): document glamour/lipgloss dual-dependency and upgrade wh…

06d9642

…ere possible - Fixes #59 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

perf(tui): cache padding string in session list render loop - Fixes #62

0fa0c01

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test(data): add coverage for Windows chronicle PTY and dbwatch ResetB…

45c6ce7

…aseline - Fixes #86 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test(platform): add coverage for session launch and terminal detectio…

119b94c

…n - Fixes #82 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test(copilot): add coverage for doAnalyze completion analysis - Fixes #…

2a54ec9

…84 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge branch 'swarm/issue-71' into swarm/integration

9faec8d

Merge branch 'swarm/issue-72' into swarm/integration

04114ec

Merge branch 'swarm/issue-81' into swarm/integration

258a2b3

Merge branch 'swarm/issue-62' into swarm/integration

5a4b8f4

Merge branch 'swarm/issue-68' into swarm/integration

949f899

Merge branch 'swarm/issue-75' into swarm/integration

c1afc3e

Merge branch 'swarm/issue-59' into swarm/integration

128ef54

Merge branch 'swarm/issue-73' into swarm/integration

8ed2a02

# Conflicts: # .github/workflows/release.yml # internal/tui/components/sessionlist.go

Merge branch 'swarm/issue-82' into swarm/integration

61e5dbd

Merge branch 'swarm/issue-84' into swarm/integration

1c3e381

Merge branch 'swarm/issue-86' into swarm/integration

14defc9

# Conflicts: # internal/data/chronicle_windows_test.go # internal/data/dbwatch_test.go

fix: resolve duplicate test names and flaky ResetBaseline test after …

5251a10

…Wave 1 merge Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix(data): handle os.UserHomeDir error in store initialization - Fixes …

7827f38

…#79 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

ci(test): add coverage profiling and artifact upload to CI - Fixes #69

fb1de2c

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

perf(data): add missing index on session_files.session_id - Fixes #60

533594d

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix(update): reuse HTTP client and propagate context for cancellation -

2dbb3a0

Fixes #64, Fixes #65 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jongio and others added 21 commits May 17, 2026 00:46

Merge branch 'swarm/issue-57' into swarm/integration

1cefa98

Merge branch 'swarm/issue-56' into swarm/integration

e029737

Merge branch 'swarm/issue-83' into swarm/integration

aef347b

Merge branch 'swarm/issue-77' into swarm/integration

5915680

Merge branch 'swarm/issue-78' into swarm/integration

c7255fd

# Conflicts: # internal/tui/model.go

refactor(tui): consolidate dot-rendering functions with shared render…

524b83f

…Dot helper - Fixes #40 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

refactor(data): deduplicate ScanAttention preamble with shared scanne…

1c9a554

…r helper - Fixes #39 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

refactor(tui): consolidate repetitive filter method pairs with shared…

4d1b789

… predicate helper - Fixes #34 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

refactor(tui): consolidate repetitive filter method pairs with shared…

05df07b

… predicate helper - Fixes #34 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix(tui): protect mutable style variables with sync.RWMutex - Fixes #51

3251051

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix(data): prefer errors.Is/As over string-based error matching where…

e2dd914

… possible - Fixes #50 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix(copilot): document intentional context.Background usage and propa…

761ed3d

…gate where safe - Fixes #52 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge branch 'swarm/issue-39' into swarm/integration

898561b

Merge branch 'swarm/issue-40' into swarm/integration

1319206

Merge branch 'swarm/issue-51' into swarm/integration

37b6aa0

Merge branch 'swarm/issue-50' into swarm/integration

f0a0e12

# Conflicts: # internal/data/store.go

Merge branch 'swarm/issue-34' into swarm/integration

b70e891

# Conflicts: # internal/tui/model.go

Merge branch 'swarm/issue-52' into swarm/integration

42f2bbd

# Conflicts: # internal/update/update.go # internal/update/update_test.go

style: apply gofmt and gofumpt formatting

d3f1ae8

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: resolve lint issues (noctx, prealloc, unparam)

3c64296

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jongio and others added 2 commits May 17, 2026 12:56

fix(lint): use exec.CommandContext in chronicle_unix.go for noctx com…

9b9916f

…pliance Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge branch 'swarm/issue-53' into swarm/integration

3826607

# Conflicts: # internal/tui/model.go

jongio changed the title ~~swarm: resolve 40 open issues across 4 parallel waves~~ Swarm: resolve issues #87-#94 (architecture, tests, performance, CI, quality) May 17, 2026

jongio and others added 3 commits May 17, 2026 15:27

Merge remote-tracking branch 'origin/main' into swarm/integration

b3278d9

# Conflicts: # go.mod # go.sum

jongio merged commit ce58066 into main May 18, 2026
2 checks passed

jongio deleted the swarm/integration branch May 18, 2026 04:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swarm: resolve issues #87-#94 (architecture, tests, performance, CI, quality)#95

Swarm: resolve issues #87-#94 (architecture, tests, performance, CI, quality)#95
jongio merged 72 commits into
mainfrom
swarm/integration

jongio commented May 17, 2026 •

edited

Loading

Uh oh!

jongio commented May 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jongio commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Issues Resolved

Changes (60 files, +3805/-1401)

Quality Gates

Uh oh!

jongio commented May 17, 2026

PR Review Summary

Security: PASS - No blocking issues. Net improvement.

Code Quality: PASS - errgroup correct, handlers extraction clean, model decomposition correct.

Non-Blocking Follow-ups

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jongio commented May 17, 2026 •

edited

Loading