Bugfix for Name-Shadowing Issues with the Schema Namespace#608
Merged
Bugfix for Name-Shadowing Issues with the Schema Namespace#608
Conversation
…User' to instead use 'Schema.User'
…o 'Profile' to instead use 'Schema.Profile'
…ces to 'Organization' to instead use 'Schema.Organization'
…ted all references to 'Topic' and 'TopicAssignment' to instead use 'Schema.Topic' and 'Schema.TopicAssignment'
…es to 'AuthSession' to instead use 'Schema.AuthSession'
…ces to 'LoginHistory' to instead use 'Schema.LoginHistory'
…o 'Account' to instead use 'Schema.Account'
….Organization) are used in the docs
1129a12 to
a9bd909
Compare
a9bd909 to
635fc60
Compare
…in the pipeline build
635fc60 to
e39decd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
=======================================
Coverage 95.69% 95.69%
=======================================
Files 48 48
Lines 5177 5178 +1
=======================================
+ Hits 4954 4955 +1
Misses 223 223
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #584 by switching to using fully-qualified Apex class references to several classes in the
Schemanamespace, likeSchema.User, to avoid collision issues in orgs that use name-shadowing classes. These class references are now fully-qualified throughout the codebaseSchema.Account(these references are only used for tests & sample recipes, not in Nebula Logger's core code)Schema.AuthSessionSchema.LoginHistorySchema.NetworkSchema.OrganizationSchema.ProfileSchema.TopicSchema.TopicAssignmentSchema.UserThis is the same concept & approach as the changes made in
v4.9.0,v4.9.4, andv4.9.6to fully-qualify references to classes & enums in theSystemnamespace.