Customization of the XHR sent by vast-vmap
#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
And threw in the ability to overwrite the used XHR constructor, because it was just 1 extra line. |
jonhoo
added a commit
that referenced
this pull request
Feb 25, 2016
Customization of the XHR sent by `vast-vmap`
Owner
|
I love it. Merged. |
This was referenced Feb 25, 2016
Closed
Contributor
Author
|
Not sure why the build failed, seems like issue with |
Owner
|
Yeah, Travis is being buggy. It was a build error, not a test failure. master built fine and passed all the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers an attempt at proposal for providing more customization of the XHRs sent by
vast-vmapas part of the fetchXML and (to a lesser extent) pixel tracking flow.Was attempting to do this in a way that had minimal impact on any existing way in which the code was used anywhere and without modifying or changing any function parameters or apis, yet still allow code calling into
vast-vmapto have a way to specify modification such aswithCredentialsor to add requestHeaders in a way that would be less contentious.Thoughts?