This repository was archived by the owner on Apr 1, 2026. It is now read-only.
Conversation
Collaborator
jonls
commented
Aug 17, 2017
jonls
commented
- Fixes Continuously update position from location provider #13 (also fixes OS X: there is no CFRunLoop #387).
- For Fallback location provider #36/Suggestion: configurable fallbacks #251/Add fallback location to redshift.conf #348/cache location information so redshift-gtk can be comfortably used with unstable internet connections #393/redshift-gtk: add an option to set default location (lat, lng) to use if no internet connection is available #396, we still don't cache the location on disk but if the location provider becomes unavailable, the last returned location is used until the location provider is able to provide updates again. In other words, at the moment we cache the last location in the running instance of redshift but not if redshift is restarted.
- This probably also fixes issues such as Startup crash if no working DNS #150, Could not get location / Provider does not have a valid location available #176, Redshift exits if no provider is found (no internet connection) #226, Unable to connect to GeoClue. Unable to get location from provider. #318, Redshift fails on startup #333 (though it doesn't fix the issues where Redshift cannot connect to GeoClue2 because the location services are not enabled/not allowed for Redshift).
Change location provider implementations so it is possible for location providers to dynamically update the location. This commit adds the interfaces and infrastructure in redshift.c but none of the location provides are changed to become dynamic.
Add pipeutils.c with utility functions for working with pipes as signals across threads. Using pipes for signals makes it easy for the main thread to wait on (multiple) file descriptors with or without a timeout.
jonls
force-pushed
the
continuous-location
branch
2 times, most recently
from
49bf650 to
cebfbcf
Compare
jonls
force-pushed
the
continuous-location
branch
from
cebfbcf to
c129e59
Compare
This was referenced Aug 19, 2017
Closed
|
"we still don't cache the location on disk but if the location provider becomes unavailable, the last returned location is used until the location provider is able to provide updates again" WHY? I just started my PC and had no internet, so I had to stare at this glaring white-blue because it couldn't track my location? Why not create a file with a few bytes in the tmp dir saving the last location? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.