Conversation
… exists before attempting providers.
network_manager_connected().
connections are available to retrieve location information.
…le a better name.
|
What if the geoclue provider that the user has chosen does not require network connection? |
|
This code executes after the "if (... mode != PROGRAM_MODE_MANUAL)" bit, so I assumed that everything non-manual would need a connection? |
|
No, it may be needed in most cases but geoclue does not strictly need a network connection (for example it can fetch the position from an attached gps device). I agree that the current situation where redshift sometimes fails because there is no connection at startup should be fixed, but I don't think this is the right way to do it. |
|
without looking at the code, it also should be noted that many DE's and linux users do NOT use networkmanager!, their are simpler lower level ways to determine connectivity. The most common technique would be to wget / curl some well know url.. if its responds your online! (ICMP won't work on many networks for this) (UGG i'm so sorry guys, i just noticed this is a year old... nevermind.. sorry) |
|
With #500, missing connectivity on startup should no longer cause Redshift to fail. If connectivity is eventually established, GeoClue2 will discover a location and report it to Redshift. |
gamma-wl: wait for sync callback on destroy
2 participants
Use NetworkManager over DBus to detect if a network connection is available before we attempt to retrieve location information.