Fix WiFi sync indicator for mobile browsers#9
Merged
Conversation
- Remove PWA requirement for WiFi sync feature since Network Information API works in Chrome mobile browser, not just PWAs - Fix syncEnabled default to true (was inconsistently false vs RemoteStorageProvider which defaults to true) - Add network.ts with utilities for detecting network type and PWA mode - Add SyncStatusProvider to manage sync status based on WiFi connection - Add WiFi-only sync toggle to preferences (shown when network info API is supported) - Add sync status indicator to article list (green cloud when active, orange cloud-off when paused on cellular) - Add Network Connection Information and Current Status sections to diagnostics page for debugging
✅ Deploy Preview for savrlist ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Deploying savr with
|
| Latest commit: |
1a7c0bf
|
| Status: | 🚫 Build failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API works in Chrome mobile browser, not just PWAs
RemoteStorageProvider which defaults to true)
API is supported)
orange cloud-off when paused on cellular)
diagnostics page for debugging