feat(pt): add support of disable_geojson parameter #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog * Add new parameters to all Public Transport related APIS * Update documentation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for the disable_geojson parameter to multiple public transportation API clients, allowing users to optionally disable GeoJSON data in API responses for improved performance when geographic data is not needed.
- Adds the
disable_geojsonboolean parameter (defaultFalse) to all methods across 11 public transportation API client classes - Updates corresponding documentation files to reflect the new parameter in method signatures
- Follows the existing codebase pattern where
disable_geojsonis already supported in other API endpoints (e.g., places_nearby_apis.py)
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| navitia_client/client/apis/public_transportation_apis/vehicle_journey_apis.py | Adds disable_geojson parameter to all four methods (list from region, get by ID, list from coordinates, get by ID and coordinates) with documentation |
| navitia_client/client/apis/public_transportation_apis/stop_point_apis.py | Adds disable_geojson parameter to all four methods with documentation |
| navitia_client/client/apis/public_transportation_apis/stop_area_apis.py | Adds disable_geojson parameter to all four methods with documentation |
| navitia_client/client/apis/public_transportation_apis/route_apis.py | Adds disable_geojson parameter to all four methods with documentation |
| navitia_client/client/apis/public_transportation_apis/physical_mode_apis.py | Adds disable_geojson parameter to all four methods with documentation |
| navitia_client/client/apis/public_transportation_apis/network_apis.py | Adds disable_geojson parameter to all four methods with documentation |
| navitia_client/client/apis/public_transportation_apis/line_apis.py | Adds disable_geojson parameter to all four methods with documentation |
| navitia_client/client/apis/public_transportation_apis/entity_apis.py | Adds disable_geojson parameter to abstract method signatures (4 methods) with partial documentation |
| navitia_client/client/apis/public_transportation_apis/disruption_apis.py | Adds disable_geojson parameter to all four methods with documentation |
| navitia_client/client/apis/public_transportation_apis/company_apis.py | Adds disable_geojson parameter to all four methods with documentation |
| navitia_client/client/apis/public_transportation_apis/commercial_mode_apis.py | Adds disable_geojson parameter to all four methods and passes it through filters dictionary |
| docs/api_support/vehicle_journeys.md | Updates method signatures to include the new parameter |
| docs/api_support/stop_points.md | Updates method signatures to include the new parameter |
| docs/api_support/stop_areas.md | Updates method signatures to include the new parameter |
| docs/api_support/routes.md | Updates method signatures to include the new parameter |
| docs/api_support/physical_modes.md | Updates method signatures to include the new parameter |
| docs/api_support/networks.md | Updates method signatures to include the new parameter |
| docs/api_support/lines.md | Updates method signatures to include the new parameter |
| docs/api_support/disruptions.md | Updates method signatures to include the new parameter |
| docs/api_support/companies.md | Updates method signatures to include the new parameter |
| docs/api_support/commercial_modes.md | Updates method signatures to include the new parameter with indentation issues |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Fix #84