Skip to content

Conversation

@jonperron
Copy link
Owner

Changelog

  • Add park_mode and is_journey_schedules parameters
  • Add some Valhalla parameters:
    • bike_use_hills
    • walking_use_hills
    • bike_avoid_bad_surfaces
    • walking_step_penalty
    • bike_maneuver_penalty
    • bike_use_living_streets

Fix #83

@jonperron jonperron added this to the 1.3.0 milestone Nov 10, 2025
@jonperron jonperron requested a review from Copilot November 10, 2025 13:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for additional journey search parameters in the Navitia API client, including parking modes and Valhalla routing preferences. The changes enable users to customize journey calculations with car parking options and fine-tune biking/walking route preferences.

Key changes:

  • Added ParkMode enum with three values: NONE, ON_STREET, and PARK_AND_RIDE
  • Added 8 new optional parameters to journey methods: park_mode, is_journey_schedules, and 6 Valhalla routing preference parameters
  • Updated documentation to reflect the new parameters

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
navitia_client/entities/journey.py Defines new ParkMode enum for car parking options
navitia_client/entities/init.py Exports ParkMode for external use
navitia_client/client/apis/journeys_apis.py Adds new parameters to all three journey API methods with corresponding filter logic
docs/api_support/journeys.md Updates method signatures to include new parameters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Changelog
* Add park_mode and is_journey_schedules parameters
* Add some Valhalla parameters:
  * bike_use_hills
  * walking_use_hills
  * bike_avoid_bad_surfaces
  * walking_step_penalty
  * bike_maneuver_penalty
  * bike_use_living_streets
* Update test
@jonperron jonperron force-pushed the feat/update_journeys_api branch from bb9efe1 to 8cb8091 Compare November 10, 2025 13:11
@jonperron jonperron merged commit 94be2ad into main Nov 10, 2025
5 checks passed
@jonperron jonperron deleted the feat/update_journeys_api branch November 10, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Valhalla routing parameters to Journeys API

2 participants