feat(freefloating): add support for freefloatings nearby API #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Navitia free-floating vehicles nearby API, enabling users to query nearby shared mobility options (bikes, scooters, cars) through multiple endpoint patterns.
Key changes:
- Introduces
FreeFloatingentity to represent shared mobility vehicles - Adds
FreefloatingsNearbyApiClientwith four query methods (by region ID, resource path, coordinates, and coordinates-only) - Includes comprehensive test coverage with mocked API responses
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_navitia_client.py | Adds integration test verifying the freefloatings_nearby client is properly instantiated |
| tests/test_data/freefloatings_nearby.json | Provides mock API response data with two sample vehicles (scooter and bike) |
| tests/client/apis/test_freefloatings_nearby_apis.py | Comprehensive unit tests for all four API methods with URL verification and data parsing assertions |
| navitia_client/entities/free_floating.py | Defines the FreeFloating dataclass with vehicle properties and payload parser |
| navitia_client/client/navitia_client.py | Registers the freefloatings_nearby property to expose the new API client |
| navitia_client/client/apis/freefloatings_nearby_apis.py | Implements the API client with four methods for different query patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changelog: * Add support for freefloating nearby APIs * Add tests
jonperron
force-pushed
the
feat/freefloating_api
branch
from
3299630 to
45741d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Fix #80