feat(api): replace dict by request objects for non-pt APIs #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog: * Add requests objects for non-pt APIs * Update functions used to call APIs to use requests objects rather than dictionnaries * Update tests
jonperron
force-pushed
the
feat/request-objects-refactor
branch
from
c3ab532 to
bc95fce
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 47 out of 47 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Whether to disable geoJSON in the response (default is False). | ||
| direction_type : str, optional | ||
| The direction type of the arrivals to fetch, e.g., "all", "forward", "backward" (default is "all"). | ||
There was a problem hiding this comment.
Missing documentation for the request parameter. Should add parameter description similar to other updated methods. Expected format:\npython\nrequest : ArrivalRequest\n The request object containing query parameters such as from_datetime,\n duration, depth, count, start_page, forbidden_uris, data_freshness,\n disable_geojson, and direction_type.\n
Suggested change
| request : ArrivalRequest | |
| The request object containing query parameters such as from_datetime, | |
| duration, depth, count, start_page, forbidden_uris, data_freshness, | |
| disable_geojson, and direction_type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: