chore: clean up documentation and infrastructure for 1.0 release

[jonpspri]

Summary

• Remove obsolete agent documentation files that are no longer actively maintained
• Remove Dockerfile and docker-compose.yml as Docker deployment is not officially supported
• Update AGENTS.md and CONTRIBUTING.md to reflect simplified workflow
• Improve test coverage for json_schema_validate module

This cleanup prepares the repository for the v1.0 release by removing unmaintained documentation and infrastructure that could confuse users.

Test plan

• All existing tests pass
• Updated test coverage for json_schema_validate
• Documentation builds successfully
• No breaking changes to core functionality

🤖 Generated with Claude Code

[Copilot]

Pull Request Overview

This PR prepares DataBeak for the v1.0 release by removing unmaintained documentation and infrastructure, updating core documentation to reflect simplified workflows, and improving test coverage for the json_schema_validate module. The changes focus on cleaning up obsolete files and improving code quality through better testing practices.

• Removes obsolete agent documentation files that are no longer actively maintained
• Removes Docker deployment infrastructure (Dockerfile and docker-compose.yml) as it's not officially supported
• Updates core documentation (AGENTS.md and CONTRIBUTING.md) to reflect simplified workflows and remove references to removed agents
• Improves test coverage by refactoring test patterns to use pytest.raises instead of manual exception handling

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/unit/core/test_json_schema_validate.py	Modernizes test patterns by replacing try/except blocks with pytest.raises
tests/integration/test_relaxed_integer_validation.py	Improves code style with pytest.raises and removes line length violations
src/databeak/core/json_schema_validate.py	Minor formatting improvements and adds noqa comment for intentional private access
docker-compose.yml	Removes Docker Compose configuration (no longer supported)
Dockerfile	Removes Docker build configuration (no longer supported)
CONTRIBUTING.md	Adds comprehensive documentation standards section with tone guidelines
AGENTS.md	Significantly streamlines agent documentation, removing obsolete content and simplifying workflow guidance
.claude/agents/*.md	Removes obsolete agent documentation files that are no longer maintained

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

[nitpick] The pytest import is added but the existing ValidationError import from jsonschema is still present on line 4. Consider organizing imports by grouping standard library, third-party, and local imports according to the project's style guide.

[Copilot]

[nitpick] The long method call is now consolidated to a single line across multiple test functions. While this fixes the line length issue, consider extracting this repeated pattern into a test fixture or helper method to reduce code duplication.

[claude]

Code Review for PR #116: Documentation and Infrastructure Cleanup

Overall Assessment

This cleanup PR successfully removes unmaintained documentation and infrastructure while improving test quality. The changes align well with DataBeak's standards for a 1.0 release.

✅ Strengths

1. Documentation Cleanup

• Removal of 5 obsolete agent documentation files (1,688 lines) reduces maintenance burden
• AGENTS.md consolidation provides clearer, more maintainable guidance
• CONTRIBUTING.md addition of documentation standards section is valuable

2. Test Improvements

• Proper use of pytest.raises context manager replaces try/except anti-pattern
• Addition of missing pytest import
• More idiomatic test structure improves readability

3. Infrastructure Simplification

• Docker removal is appropriate given it's not officially supported
• Reduces confusion about deployment options

🔍 Observations & Suggestions

1. Code Quality

• JSON schema validate changes are minimal and safe (type annotation cleanup)
• Test refactoring follows pytest best practices
• No ruff/mypy violations introduced

2. Minor Issues

• Missing newline at EOF in test_relaxed_integer_validation.py (line 178)
• Consider whether test coverage improvements mentioned in PR description are sufficient

3. Documentation Tone Guidelines
The new CONTRIBUTING.md section on avoiding self-aggrandizing language is excellent and aligns with Claude Code style principles.

🔒 Security & Performance

• No security concerns identified
• No performance implications (documentation/test-only changes)
• No changes to production code beyond type annotation cleanup

✅ Verification Checklist

• Branch naming follows convention (pre-release-cleanup)
• No direct commits to main
• Changes align with CLAUDE.md guidelines
• Test improvements follow pytest patterns
• Documentation consolidation reduces maintenance burden

Recommendation

APPROVED - This PR effectively prepares the repository for v1.0 release by removing technical debt and improving clarity. The cleanup is thorough and well-scoped.

The systematic removal of unmaintained documentation and unofficial deployment options will prevent user confusion, while the test improvements demonstrate commitment to code quality.

[claude]

Pull Request Review

Overview

This PR performs essential cleanup for the v1.0 release by removing unmaintained documentation and Docker infrastructure while improving test coverage for the json_schema_validate module. The changes align well with simplifying the repository and focusing on core functionality.

✅ Positive Aspects

1. Focused Cleanup: Removal of 2,112 lines of unmaintained agent documentation reduces confusion and maintenance burden
2. Test Coverage Improvement: Comprehensive test suite for json_schema_validate with excellent edge case coverage
3. Documentation Simplification: AGENTS.md and CONTRIBUTING.md updates provide clearer guidance without unnecessary complexity
4. Following Best Practices: Changes respect the branch-based workflow and quality gates mentioned in CLAUDE.md

🔍 Code Quality Analysis

src/databeak/core/json_schema_validate.py

• ✅ Clean implementation of relaxed integer validation for LLM compatibility
• ✅ Proper use of global state management with clear documentation
• ✅ Good defensive comments explaining the private API usage (_LATEST_VERSION)
• ⚠️ Consider adding a version check or feature flag for the private API usage to ease future migrations

Test Coverage (tests/unit/core/test_json_schema_validate.py)

• ✅ Comprehensive unit tests covering all validation scenarios
• ✅ Direct testing of type checker functionality
• ✅ Good test naming and organization
• ✅ Tests for edge cases (empty strings, fractional floats, negative values)

Integration Tests (tests/integration/test_relaxed_integer_validation.py)

• ✅ Practical testing with actual MCP tool calls
• ✅ Coverage of real-world LLM scenarios (strings as integers, floats as integers)
• ✅ Proper async test patterns
• ✅ Good error case handling with appropriate exception matching

🚨 Potential Issues

1. Private API Dependency: The code modifies validators._LATEST_VERSION which is a private API. While documented, consider:

   • Adding a feature detection mechanism to check if a public API becomes available
   • Creating a wrapper function to isolate this dependency

2. Global State Modification: The initialize_relaxed_validation() function modifies global state. Consider:

   • Documenting where/when this initialization occurs in the application lifecycle
   • Adding idempotency checks to prevent multiple initializations

🔒 Security Considerations

• ✅ No security vulnerabilities identified
• ✅ Input validation remains robust with the relaxed integer checking
• ✅ No credentials or sensitive information exposed

📊 Performance Considerations

• ✅ Minimal overhead from the custom type checker
• ✅ The is_integer() check is efficient with early returns
• ✅ No performance regression expected

💡 Suggestions for Improvement

1. Add Migration Path Documentation: Consider adding a comment or documentation about monitoring jsonschema releases for a public API to replace the private _LATEST_VERSION usage

2. Consider Configuration Option: For future flexibility, consider making relaxed validation configurable via environment variable or settings

3. Test Fixture Enhancement: The integration tests could benefit from a shared fixture for CSV loading to reduce duplication

✅ Overall Assessment

APPROVED - This PR successfully cleans up the repository for v1.0 release while maintaining code quality and improving test coverage. The removal of unmaintained documentation is appropriate, and the enhanced testing for json_schema_validate adds valuable robustness for LLM interactions.

The changes are well-structured, follow the project's coding standards, and include comprehensive testing. The minor suggestions above are for future consideration and don't block the current changes.

🤖 Review generated with Claude Code