Conversation
Current coverage is 27.51% (diff: 63.15%)@@ master #51 diff @@
==========================================
Files 45 45
Lines 1321 1334 +13
Methods 169 169
Messages 0 0
Branches 307 313 +6
==========================================
+ Hits 264 367 +103
+ Misses 1057 967 -90
Partials 0 0
|
|
This looks good. Can you add some a couple unit tests and if you're feeling ambitious a protractor test for sorting+paging on the demo? |
jonshaffer
left a comment
jonshaffer
left a comment
There was a problem hiding this comment.
Could use some related unit tests, bodyController already has a spec started too which should make that easier
| }); | ||
| }, 200) | ||
| }; | ||
| <head> |
There was a problem hiding this comment.
it looks like you tabbed <head at the same level of <html?
There was a problem hiding this comment.
Yeah, VS Code doesn't do a great job at auto-formatting. I'll fix.
| { name: "Name", prop: "name" }, | ||
| { name: "Gender", prop: "gender" }, | ||
| { name: "Company", prop: "company" } | ||
| { name: "Name", prop: "name", sortable: false }, |
There was a problem hiding this comment.
looks like we could use a global 'sortable'!
| while (idx < idxs.last) { | ||
| this.tempRows.push(rows[idx++]) | ||
| } | ||
| } else if (this.options.paging.size) { |
There was a problem hiding this comment.
It looks like this is nested in a this.options.paging.size already, which would prevent the next else statement from ever firing. Looks safe to remove the if condition and the else below it, but you may know more about this area than me now :)
That being said - do we know the relation of the externalPaging logic to all of that paging that happens in virtual paging?
3 participants
Added the internal paging feature, so sorting now works on the paging demo.
Disabled sorting on the virtual paging demo, since built-in sorting is incompatible at this time.
Works to include fix for #33