Thrown an error when a private method has MVC annotations

[danielfireman]

I've just ran into this problem. For instance:

public class PingRoute {
  @Path("/ping")
  @GET
   private ping() {
     return Results.ok()
   }
}

If I use(PingRoute.class), the ping endpoint is silently ignored. Although I know that we could easily add unit tests to find this error, I think that we could also follow a fail-fast approach and prevent the server from start (giving a nice error message).

What do you guys think? I am happy to give it a shot as soon I get some sort of thumbs up.

[jknack]

We used to have the check, but then I removed it here

I removed bc it was dead code. For example the .getMethods() only returns public methods, before we were using .getDeclaredMethods

The challenge here is to supports #365 in an easy way and taking care of method overrides. This was the main reason of the change.

I'm cool to getting this back and there are enough tests to validate what I explained here.

Thanks!

[jknack]

Oh, don't forget to start the project and follow us at twitter