[v1] Test fixes for windows path separators, line endings #1389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknack
requested changes
Sep 17, 2019
| " \"name\" : \"pablo\"\n" + | ||
| "} ]"); | ||
| request().get("/members").expect(value -> | ||
| assertEquals("[ {\n" + |
Member
There was a problem hiding this comment.
the .expect is part of Jooby testing code... a better option is to make the change there and not per each test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes:
Failure to start Jooby in JoobyRunner should fail the suite early - otherwise the tests will fail later with cryptic exception
org.apache.http.conn.HttpHostConnectException: Connect to localhost:9999 [localhost/127.0.0.1, localhost/0:0:0:0:0:0:0:1] failed: Connection refused: connectAssets pipeline tests fail if there is no
assets.confin test path. Empty assets.conf seems to fix this.Relax json tests to accept both "\r\n" and "\n" in output for windows(jackson seems to return platform-dependent line endings)
In some places(css sprites) we should not use system path separator - the css sprites results are URLS, the path separator there is always /.
In some places (tmpdir), we should use system path separator so our tests dont fail
Before the change: 9 errors, 19 failures https://altio.us/files/Test%20Results%20-%20TestAllorg_jooby.html
After the change: https://altio.us/files/Test%20Results%20-%20TestAllorg_jooby2.html
(I dont know how to fix whoops, sorry)