Exposes Servlet Request attributes#676
Merged
jknack merged 3 commits intojooby-project:masterfrom Mar 20, 2017
andrenpaes:servlet-request-attributes
Merged
Exposes Servlet Request attributes#676jknack merged 3 commits intojooby-project:masterfrom andrenpaes:servlet-request-attributes
jknack merged 3 commits intojooby-project:masterfrom
andrenpaes:servlet-request-attributes
Conversation
jknack
reviewed
Mar 19, 2017
Member
jknack
left a comment
jknack
left a comment
There was a problem hiding this comment.
Looks good, did some minor comments. Please amend your commit and update your pull.
Thank you.
|
|
||
| @Override | ||
| public Map<String, Object> attributes() { | ||
| final Enumeration<String> attributeNames = req.getAttributeNames(); |
| final Enumeration<String> attributeNames = req.getAttributeNames(); | ||
| if (!attributeNames.hasMoreElements()) { | ||
| return Collections.emptyMap(); | ||
| } |
Member
There was a problem hiding this comment.
split this line and leave one method call per line. Also for name -> name, use Function.identity()
jknack
approved these changes
Mar 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #674
I couldn't really find a good place to write a test to the
HttpHandlerImplchange, but since it's a small, simple change, maybe we're good without a test.Anyway, if you think it's worth it I can write the test, I'd just need a pointer to specific test case I could use.