Conversation
| * @param err An err callback. | ||
| * @throws Exception If something goes wrong. | ||
| */ | ||
| void broadcast(final Object data, final SuccessCallback success, final OnError err) |
Member
There was a problem hiding this comment.
Final on interface method that are not default makes no sense since they do not affect the actual implementation.
|
|
||
| @Override | ||
| public void broadcast(final Object data, final SuccessCallback success, final OnError err) | ||
| throws Exception { |
Member
There was a problem hiding this comment.
The broadcast terminates on the first error. Wouldn't it be better to try to send to all endpoint, log the exception and throw a new one if there was at least one failure?
krisztiankocsis
suggested changes
Mar 21, 2017
Member
krisztiankocsis
left a comment
krisztiankocsis
left a comment
There was a problem hiding this comment.
See my two recommendations.
Member
Author
|
@krisztiankocsis thank you, I update the pull with your comments. You're right about broadcast error, but I didn't rethrow anything. Instead, I used the error callback to notify about a possible error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.