Skip to content

Jooby overriding Content-Type header fix #730 #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jknack merged 1 commit into from
Apr 24, 2017
Merged

Jooby overriding Content-Type header fix #730 #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions coverage-report/src/test/java/org/jooby/issues/Issue730.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
package org.jooby.issues;

import org.jooby.test.ServerFeature;
import org.junit.Test;

public class Issue730 extends ServerFeature {

{
get("/730", (req, rsp) -> {
rsp.header("content-type", "application/json");
rsp.send("{\"issue\": \"730\"}");
});

}

@Test
public void contentTypeShouldWorkFromSetHeader() throws Exception {
request().get("/730")
.execute()
.header("Content-Type", "application/json;charset=utf-8");
}

}
4 changes: 4 additions & 0 deletions jooby/src/main/java/org/jooby/internal/ResponseImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,10 @@ private Response setHeader(final String name, final Object value) {
}
rsp.header(LOCATION, location);
} else {
if ("Content-Type".equalsIgnoreCase(name)) {
// keep type reference
this.type = MediaType.valueOf(value.toString());
}
rsp.header(name, Headers.encode(value));
}
}
Expand Down