Rename standalone 'phase' artifacts to readiness/functional names#10
Merged
Rename standalone 'phase' artifacts to readiness/functional names#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
standalonePhase*/Phase*to descriptive readiness names and signatures (for examplestandalonePhase1.ts→prototypeReadiness.ts,evaluatePhase1→evaluatePrototypeReadiness,REQUIRED_PHASE1_COMMANDS→REQUIRED_PROTOTYPE_COMMANDS).src/test/standalonePhase1.test.ts→src/test/prototypeReadiness.test.ts) and updated imports/expectations to use the new readiness strings.phase4.rs→command_porting.rsandphase5.rs→cutover.rs, updated public constants/struct/enum/function names (for exampleevaluate_phase4→evaluate_command_porting,REQUIRED_PHASE4_EXECUTION_COMMANDS→REQUIRED_EXECUTION_COMMANDS) and adjustedmain.rsmodule wiring and top-level command constant (PHASE3_COMMANDS→SUPPORTED_TOP_LEVEL_COMMANDS).docs/standalone/to descriptive names (phase1.md/phase2.md/phase3.md/phase5.md→prototype.md/distribution.md/native-foundation.md/cutover.md) and revised TODO headings/phrasing to an implementation workstreams model.build/check-setup-separation.jsnow matches/(?:.*Readiness)\.ts$/and error messages reference readiness evaluators;scripts/standalone/build-linux-x64.shwording updated).Testing
npm run check-setup-separationand it passed.env TS_NODE_PROJECT=src/test/tsconfig.json npx mocha -r ts-node/register --exit src/test/prototypeReadiness.test.ts src/test/distributionReadiness.test.ts src/test/nativeFoundationReadiness.test.ts src/test/cutoverReadiness.test.tsand all tests passed (9 passing).cargo testincmd/devcontainer-nativeand they passed (11 passed).Codex Task