CI: publish standalone release artifacts and update permissions/runner#13
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f4867ca57
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| files: | | ||
| ${{ env.ARTIFACT }} | ||
| ${{ env.ARTIFACT }}.sha256 | ||
| ${{ env.ARTIFACT }}.sha256.sig | ||
| ${{ env.ARTIFACT }}.sha256.pem |
There was a problem hiding this comment.
Publish runtime payload with standalone release asset
The new release step uploads only ${{ env.ARTIFACT }} and checksum/signature files, but the produced "standalone" binary is currently a wrapper script that executes spec-node/devContainersSpecCLI.js from the same directory (scripts/standalone/build.sh). On tag builds this makes the GitHub Release artifact non-runnable for users who download it directly, because dist/standalone/spec-node/** is omitted from the release assets even though it is required at runtime (and is included in upload-artifact).
Useful? React with 👍 / 👎.
|
@codex fix comment |
Summary
Testing
|
Motivation
Description
.github/workflows/standalone-release.ymlto setcontents: writein jobpermissionsso release assets can be published.macos-13tomacos-15-intel.softprops/action-gh-release@v2to publish the standalone artifact and its checksum/signature when the workflow is triggered by a tag (if: startsWith(github.ref, 'refs/tags/')).actions/upload-artifact@v4upload steps; the release step posts the same files to the GitHub Release.Testing
Codex Task