a try to build on github actions #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterIvanov
requested changes
Apr 6, 2021
.github/workflows/ci.yml
Outdated
|
|
||
| strategy: | ||
| matrix: | ||
| # go: [1.8, 1.9, '1.10'] |
Collaborator
There was a problem hiding this comment.
Trial and error leftovers?
Contributor
Author
There was a problem hiding this comment.
Was going to left it for the next PR, but fixed now.
.github/workflows/ci.yml
Outdated
| with: | ||
| go-version: ${{ matrix.go }} | ||
| # - name: "Setup dependencies" | ||
| # if: ${{ matrix.go == '1.8' }} |
Collaborator
There was a problem hiding this comment.
So the tests are currently not run against earlier go versions? No way to fix this?
PeterIvanov
approved these changes
Apr 7, 2021
Collaborator
PeterIvanov
left a comment
PeterIvanov
left a comment
There was a problem hiding this comment.
Great, thanks, Ivan! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github actions seems much faster than Travis (maybe we should invest some time in optimizing travis build).