Skip to content

Restructure application class tests#45

Merged
wilsonge merged 6 commits into
masterfrom
RestructureAppTests
Jul 17, 2015
Merged

Restructure application class tests#45
wilsonge merged 6 commits into
masterfrom
RestructureAppTests

Conversation

@mbabker
Copy link
Copy Markdown
Contributor

@mbabker mbabker commented Jul 15, 2015

Restructure's AbstractApplicationTest, AbstractCliApplicationTest, and AbstractWebApplicationTest to use the PHPUnit API for mocking objects (concrete and abstract) and our own API for injecting objects versus using our Reflection based TestHelper to manipulate the class variables. Also uses PHPUnit's assertions to test the objects as appropriate and deal with instances where we need to adjust values in superglobals.

@mbabker mbabker force-pushed the RestructureAppTests branch from 0c11e2b to 005c777 Compare July 15, 2015 00:18
@mbabker mbabker changed the title Restructure AbstractApplicationTest Restructure application class tests Jul 15, 2015
@wilsonge
Copy link
Copy Markdown
Contributor

This looks good to me

@mbabker
Copy link
Copy Markdown
Contributor Author

mbabker commented Jul 17, 2015

@wilsonge Merge if you're good with this. After your changes in #47 there's nothing left in the web test case that's actually altering $_SERVER now; everything is fully mocked and injected.

wilsonge added a commit that referenced this pull request Jul 17, 2015
@wilsonge wilsonge merged commit 5825e9f into master Jul 17, 2015
@wilsonge wilsonge deleted the RestructureAppTests branch July 17, 2015 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants