prevent dwonload of unpausible response bodies #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeutz
approved these changes
Oct 27, 2025
brianteeman
reviewed
Oct 27, 2025
Co-authored-by: Brian Teeman <brian@teeman.net>
HLeithner
approved these changes
Oct 27, 2025
brianteeman
reviewed
Oct 27, 2025
app/RemoteSite/Connection.php
Outdated
| $downloadedBytes | ||
| ) use ($request) { | ||
| if ($downloadedBytes > 1024000) { | ||
| throw new \RuntimeException("Unplausible response size while fetchting from " . $request->getUri()); |
Contributor
There was a problem hiding this comment.
do you mean can not be paused?
==> un-pausable
or do you mean not believable?
==>implausible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.