Skip to content

prevent dwonload of unpausible response bodies #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

prevent dwonload of unpausible response bodies #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0457480
prevent dwonload of unpausible response bodies
SniperSister Oct 27, 2025
57166e9
Update app/RemoteSite/Connection.php
HLeithner Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions app/RemoteSite/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use GuzzleHttp\Exception\RequestException;
use GuzzleHttp\Psr7\Request;
use GuzzleHttp\Psr7\Response;
use GuzzleHttp\Psr7\Utils;
use Illuminate\Support\Facades\App;
use Psr\Http\Message\RequestInterface;

Expand Down Expand Up @@ -121,12 +122,33 @@ protected function performHttpRequest(
/** @var Client $httpClient */
$httpClient = App::make(Client::class);

// Send a streamed response to be able to validate the size
$options['stream'] = true;
$options['progress'] = function (
$downloadTotal,
$downloadedBytes
) use ($request) {
if ($downloadedBytes > 1024000) {
throw new \RuntimeException("Unplausible response size while fetching from " . $request->getUri());
}
};

/** @var Response $response */
$response = $httpClient->send(
$request,
$options
);

// Convert the streamed response into a "normal" one
$buffer = '';

while (!$response->getBody()->eof()) {
$buffer .= $response->getBody()->read(8192);
}

// Overwrite streamed body
$response = $response->withBody(Utils::streamFor($buffer));

// Validate response
if (!json_validate((string) $response->getBody())) {
throw new RequestException(
Expand Down