#92 [phpcs] Apply coding standard changes #106
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/JoomlaBrowser.php
Outdated
| else : | ||
| $this->debug('I install Joomla without Sample Data'); | ||
| $I->selectOption('#jform_sample_file', '#jform_sample_file0'); // No sample data | ||
| endif;*/ |
Contributor
There was a problem hiding this comment.
Don't leave any commented code.
https://medium.com/@kentcdodds/please-don-t-commit-commented-out-code-53d0b5b26d5f#.n7t3shymb
Contributor
Author
There was a problem hiding this comment.
I leave it because it says @todo there. I will remove it.
Contributor
|
Hi @pritalpatel, your PR has one big problem. Your tab is 8 spaces long and not 4. Can you adjust that please? Thank you :) |
Conflicts: src/JoomlaBrowser.php
pritalpatel
force-pushed
the
codeStyle-92
branch
from
83a4daf to
29678b4
Compare
Contributor
Author
|
Thanks @yvesh Actually that problem with 8 char was because of I have fixed conflict with meld tool. Now, I have corrected it from Sublime Text. So, should be fine now.
|
Contributor
|
closing for #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @yvesh for suggestions.
Send Coding standard changes for #92