Skip to content

Fix installExtensionFromFolder on J36 #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2016
Merged

Fix installExtensionFromFolder on J36 #113

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0b65b6
Fix installExtensionFromFolder on J36
May 8, 2016
81fd89f
Also fix from url
May 8, 2016
9dc3b83
Update id names
May 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/JoomlaBrowser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,8 +328,7 @@ public function installExtensionFromFolder($path, $type = 'Extension')
$I->click(['link' => 'Install from Folder']);
$this->debug('I enter the Path');
$I->fillField(['id' => 'install_directory'], $path);
// @todo: we need to find a better locator for the following Install button
$I->click(['xpath' => "//button[contains(@onclick,'Joomla.submitbutton3()')]"]); // Install button
$I->click(['id' => 'installbutton_directory']); // Install button
$I->waitForText('was successful','60', ['id' => 'system-message-container']);
$this->debug("$type successfully installed from $path");
}
Expand All @@ -349,9 +348,8 @@ public function installExtensionFromUrl($url, $type = 'Extension')
$I->waitForText('Extensions: Install','30', ['css' => 'H1']);
$I->click(['link' => 'Install from URL']);
$this->debug('I enter the url');
$I->fillField(['id' => 'install_url'], $url);
// @todo: we need to find a better locator for the following Install button
$I->click(['xpath' => "//button[contains(@onclick,'Joomla.submitbutton4()')]"]); // Install button
$I->fillField(['id' => 'install_url'], $url);
$I->click(['id' => 'installbutton_url']); // Install button
$I->waitForText('was successful','30', ['id' => 'system-message-container']);
if ($type == 'Extension')
{
Expand Down