Skip to content

Updated to newest robo and joomla testing robo dependencies #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2016
Merged

Updated to newest robo and joomla testing robo dependencies #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d9adc7
Updated to newest robo and joomla testing robo dependencies
jatitoam Dec 14, 2016
881290d
Updated PHP requirements for matching
jatitoam Dec 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
language: php
php:
- 5.4
- 5.5
before_script:
- composer install

Expand Down
31 changes: 8 additions & 23 deletions RoboFile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,7 @@
class RoboFile extends \Robo\Tasks
{
// Load tasks from composer, see composer.json
use \joomla_projects\robo\loadTasks;

private $extension = '';

/**
* Set the Execute extension for Windows Operating System
*
* @return void
*/
private function setExecExtension()
{
if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN')
{
$this->extension = '.exe';
}
}
use Joomla\Testing\Robo\Tasks\loadTasks;

/**
* Check the code style of the project against a passed sniffers using PHP_CodeSniffer_CLI
Expand All @@ -34,15 +19,15 @@ public function checkCodestyle($sniffersPath = null)
{
if (is_null($sniffersPath))
{
$this->say('Downloading Joomla Coding Standards Sniffers');
$this->_exec("git $this->extension clone -b master --single-branch --depth 1 https://github.com/joomla/coding-standards.git .travis/phpcs/Joomla");
$sniffersPath = __DIR__ . '/.travis/phpcs/Joomla';
}

$this->taskCheckCodeStyle()
->inspect(__DIR__ . '/src')
->dontStopOnFail(true)
->standard($sniffersPath)
->run();
$this->taskCodeChecks()
->setBaseRepositoryPath(__DIR__)
->setCodeStyleStandardsFolder($sniffersPath)
->setCodeStyleCheckFolders(['/src'])
->checkCodeStyle()
->run()
->stopOnFail();
}
}
28 changes: 14 additions & 14 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,29 @@
{
"name": "joomla-projects/joomla-browser",
"description": "joomla-browser Codeception Module",
"keywords":["BDD", "acceptance testing", "tdd", "joomla"],
"homepage":"https://docs.joomla.org/Testing_Joomla_Extensions_with_Codeception",
"license": "GPL-2.0+",
"authors": [
"name" : "joomla-projects/joomla-browser",
"description" : "joomla-browser Codeception Module",
"keywords" : ["BDD", "acceptance testing", "tdd", "joomla"],
"homepage" : "https://docs.joomla.org/Testing_Joomla_Extensions_with_Codeception",
"license" : "GPL-2.0+",
"authors" : [
{
"name": "Puneet Kala",
"email": "puneet.kala@community.joomla.org"
"name" : "Puneet Kala",
"email" : "puneet.kala@community.joomla.org"
},
{
"name": "Javier Gomez",
"email": "javier.gomez@community.joomla.org"
"name" : "Javier Gomez",
"email" : "javier.gomez@community.joomla.org"
}
],
"require": {
"php": ">=5.3.0"
"php" : ">=5.5.9",
Copy link
Contributor Author

@jatitoam jatitoam Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the new requirements in the latest consolidation/robo source and some Symfony dependencies, I see no way but to upgrade the requirement of Joomla Browser (Robo-based) to a minimum of PHP 5.5.9.

That means we will limit the environments a Robo script can run in to 5.5.9 and above.

However, if we really need to add PHP 5.3 and 5.4 for testing purposes, we could later do workarounds in the actual testing scripts (not the Docker-based environment since that one should run in latest PHP 7.x) so they can run in such PHP versions.

Leaving it for discussion @yvesh @javigomez @puneet0191

Copy link
Contributor Author

@jatitoam jatitoam Dec 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a second thought, no workaround will be needed after all, since all Selenium clients (with Robo) will run in latest PHP 7.x, while only servers will vary Joomla version, so it should not be an impediment for anything.

"consolidation/robo" : "~1"
},
"require-dev": {
"codegyre/robo": "^0.5.3",
"joomla-projects/robo": "dev-master"
"joomla-projects/joomla-testing-robo" : "~1.0"
},
"autoload": {
"psr-4": {
"Codeception\\Module\\": "src"
"Codeception\\Module\\" : "src"
}
}
}
Loading